ci(interop): Use run-interop-ping-test master latest hash#3462
ci(interop): Use run-interop-ping-test master latest hash#3462mxinden merged 5 commits intolibp2p:masterfrom
Conversation
With libp2p/test-plans#121 merged, we should be able to use @master directly. This includes libp2p/test-plans@6d1aed2, thus allowing interop tests to run from fork pull requests.
This reverts commit b4fb343.
|
I am assuming that the specific git commit hash was meant to be temporary, thus changing to |
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
NACK
The specific commit was to make sure the repos don't break if test-plans changes. I'd like to keep it. Does dependabot not send update PRs for this?
|
Dependabot has not send an update PR. I am assuming that this is due to the previous commit hash not being part of libp2p/test-plans I will reference a git commit hash instead of |
mxinden
changed the title
|
Retriggered @thomaseizinger pointing to a concrete git commit now, thus dismissing your review. Will merge to unblock other pull requests. Please still review when you have time. |
2 participants
Description
With libp2p/test-plans#121 merged, we should be able to use master directly. This commit references the latest test-plans commit hash.
This includes
libp2p/test-plans@6d1aed2, thus allowing interop tests to run from fork pull requests.
Notes
Links to any relevant issues
Open Questions
Change checklist
A changelog entry has been made in the appropriate crates